Combined selection format to ignore empty text nodes #5521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
ivailop7
approved these changes
Jan 19, 2024
| const nodesLength = nodes.length; | ||
| const isBackward = selection.isBackward(); | ||
| const startOffset = isBackward ? focusOffset : anchorOffset; |
There was a problem hiding this comment.
I think it would be better to do an old-fashioned if/else here, since it will end up with 1 comparison and 4 assignments vs 4 comparisons and 4 assignments, or does this have some minification benefits?
There was a problem hiding this comment.
Nevermind, you'll need to do it with closure outside the if, so you'd end up with 1 comparison but 4 declarations and 4 reassignments. Doubt it will make any difference in bundle size or minification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending #5126 to exclude all empty text nodes as well as the resulting from the user's selection (which may not span the entire TextNode).