Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Grid to @lexical/table #5528

Merged
merged 2 commits into from Jan 24, 2024
Merged

Move Grid to @lexical/table #5528

merged 2 commits into from Jan 24, 2024

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented Jan 22, 2024 •
edited

We don't want Grid modules inside the Core either, move these ones to the @lexical/table package

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 22, 2024
@vercel Vercel
Copy link

vercel bot commented Jan 22, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 4:29pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 4:29pm

@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.66 KB (0%) 534 ms (0%) 62 ms (+116.37% 🔺) 596 ms
packages/lexical-rich-text/dist/LexicalRichText.js 38.72 KB (-1.73% 🔽) 775 ms (-1.73% 🔽) 80 ms (+90.94% 🔺) 855 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 38.69 KB (-1.74% 🔽) 774 ms (-1.74% 🔽) 54 ms (+46.47% 🔺) 828 ms

@zurfyx zurfyx changed the title [WIP] Move Grid to @lexical/table Move Grid to @lexical/table Jan 23, 2024
@zurfyx zurfyx marked this pull request as ready for review January 23, 2024 16:32
ivailop7
ivailop7 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@ivailop7 ivailop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@zurfyx zurfyx merged commit 1154413 into main Jan 24, 2024
41 of 45 checks passed
@zurfyx zurfyx deleted the table-away-from-core branch January 24, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zurfyx @ivailop7 @facebook-github-bot