Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename GridSelection to TableSelection #5534

Merged
merged 4 commits into from Jan 24, 2024
Merged

Rename GridSelection to TableSelection #5534

merged 4 commits into from Jan 24, 2024

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented Jan 23, 2024

Having renamed the badly named TableSelection, we can now rename GridSelection to TableSelection and this concludes the existance of GridSelection.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 23, 2024
@vercel Vercel
Copy link

vercel bot commented Jan 23, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 3:48pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 3:48pm

ivailop7
ivailop7 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@ivailop7 ivailop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zurfyx zurfyx changed the base branch from away4 to main January 24, 2024 15:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.66 KB (0%) 534 ms (0%) 56 ms (+311.35% 🔺) 589 ms
packages/lexical-rich-text/dist/LexicalRichText.js 38.72 KB (0%) 775 ms (0%) 64 ms (+226.06% 🔺) 838 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 38.69 KB (0%) 774 ms (0%) 58 ms (+273.1% 🔺) 832 ms

@zurfyx zurfyx merged commit 08f61ba into main Jan 24, 2024
38 of 45 checks passed
@zurfyx zurfyx deleted the away5 branch January 24, 2024 15:52
@etrepum etrepum mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zurfyx @ivailop7 @facebook-github-bot