Floating link editor for AutoLinkNode and conversion to LinkNode once modified. #5536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarrySIV
requested review from
zurfyx,
fantactuka and
acywatson
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
zurfyx
reviewed
Jan 24, 2024
Comment on lines
200
to
202
| }).append($createTextNode(parent.getURL())); | ||
| parent.getParent()?.append(linkNode); | ||
| parent.remove(); |
There was a problem hiding this comment.
Let's use replace instead, guarantees the correct position with the best performance.
- Replace the parent:
parent.replace(linkNode) - Move the children: traverse all the children in parent and append them into
linkNode
There was a problem hiding this comment.
I tried using .replace() and it kept crashing my browser but I'll try again
|
Sorry about that @zurfyx, ran into some weird issues after having to rebase the branch due to the changes to main. Should work perfectly fine and as intended now. |
zurfyx
approved these changes
Jan 25, 2024
packages/lexical-playground/src/plugins/FloatingLinkEditorPlugin/index.tsx
Outdated
Show resolved
Hide resolved
|
LGTM, thanks Harry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4202 as well as satisfies @zurfyx request in #4203 to have the AutoLinkNode be converted to a LinkNode once modified in the floating link editor toolbar.
I saw multiple closed PR's for this and it looked like it was still an issue no one was currently working on.
Please let me know if there's anything I need to change, I know the conversion logic is kind of ugly.