-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbullet one list item not the whole list #5621
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Nice! I'm really surprised this works, as we have a bunch of logic in the lists module to split the lists in various nesting situations. I wonder if this means we can get rid of that stuff, if setBlocksType is handling it well... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! As Acy indicated, I wonder if we can simplify the lists code.
Besides that, would be nice to have an external module to share toolbar code so that we don't have to replicate the fixes elsewhere now, I'll put it on our shared list
Looks like we still do have 3 lists tests consistently failing |
will look into this again over the weekend |
@acywatson tests fixed |
Before
2024-02-17_15-35-59.mp4
After
2024-02-17_15-36-56.mp4
Fixes #5039