Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape Layout Plugin #5626

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Escape Layout Plugin #5626

merged 1 commit into from
Feb 21, 2024

Conversation

ivailop7
Copy link
Collaborator

Fixes #5375

Up/Left Arrow when no node above Columns layout add a paragraph before or Down/Right Arrow add a paragraph below if such doesn't exist. I've used the Collapsible section logic, just simplified it a bit.

Copy link

vercel bot commented Feb 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2024 7:19pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2024 7:19pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 18, 2024
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping to unblock but I think it's worth discussing on our next sync. Block cursors were supposed to fix this problem in a generic manner. The fact that we need this code in place probably means we need a better generic solution

@ivailop7 ivailop7 merged commit 9a63305 into facebook:main Feb 21, 2024
33 of 45 checks passed
@ivailop7 ivailop7 deleted the escape_layout_plugin branch February 21, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
3 participants