Configure ESLint: enable curly rule, fix on save #5666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorn0
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
fantactuka
reviewed
Feb 28, 2024
| @@ -1,8 +1,7 @@ | |||
| { | |||
| "editor.defaultFormatter": "esbenp.prettier-vscode", | |||
| "eslint.alwaysShowStatus": true, | |||
There was a problem hiding this comment.
Do we have to remove it?
There was a problem hiding this comment.
VS Code says "Unknown Configuration Setting".
thorn0
commented
Feb 28, 2024
| @@ -272,7 +272,9 @@ export class CodeNode extends ElementNode { | |||
| let spaces = 0; | |||
| const text = node.getTextContent(); | |||
| const textSize = node.getTextContentSize(); | |||
| for (; spaces < textSize && text[spaces] === ' '; spaces++); | |||
There was a problem hiding this comment.
ESLint adds empty braces here and then complains about an empty block, so I changed this to while.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.