Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix E2E tests in Safari (Webkit) #5672

Merged
merged 1 commit into from
Mar 1, 2024
Merged

fix: Fix E2E tests in Safari (Webkit) #5672

merged 1 commit into from
Mar 1, 2024

Conversation

StyleT
Copy link
Contributor

@StyleT StyleT commented Feb 29, 2024 •
edited

Few root causes here:

  1. Caused by special handling for Webkit in tests. Apparently now it's fine to remove it
  2. Selection in Webkit still works somehow differently to other browsers but in tests that are not related to selection it's OK to remove this extra check as it brings not value but causes flakiness
  3. CDP session is only available in Chromium

@vercel Vercel
Copy link

vercel bot commented Feb 29, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 1:37am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 1:37am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 29, 2024
@StyleT StyleT changed the title [WIP] fix: This fixes some E2E test in Safari (Webkit) [WIP] fix: This fixes some E2E tests in Safari (Webkit) Feb 29, 2024
@StyleT StyleT mentioned this pull request Mar 1, 2024
Open
@StyleT
fix: This fixes some E2E tests in Safari (Webkit)
1a726e0 
Few root causes here:
1. Caused by special handling for Webkit in tests. Apparently now it's fine to remove it
2. Selection in Webkit still works somehow differently to other browsers but in tests that are not related to selection it's OK to remove this extra check as it brings not value but causes flakiness
@StyleT StyleT changed the title [WIP] fix: This fixes some E2E tests in Safari (Webkit) fix: Fix E2E tests in Safari (Webkit) Mar 1, 2024
@StyleT StyleT marked this pull request as ready for review March 1, 2024 01:51
ivailop7
ivailop7 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@ivailop7 ivailop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! Thank you vm!

@ivailop7 ivailop7 merged commit 9445ed2 into facebook:main Mar 1, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StyleT @ivailop7 @facebook-github-bot