Fix check for menu cannot fit on top #5743
Conversation
JingkangZhang
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @JingkangZhang! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
issue #5740
Originally, the check doesn't consider the resolution height, but the resolution height is being used below to determine the style.top. This causes the element to overlap with the parent box, and in turn causes the menu to close onScroll, because of the check here.
Add the height check to the RHS of the > , so the menu won't be placed on the top if it cannot fit.
Taking a step back, I'm not sure why when the menu is placed on top of the cursor, it's
heightlength away from the cursor, whereas when the menu is placed below the cursor, it's 0 length away from the cursor. In other words, we could have removed both+ heighton line 519 and- heighton line 522, but I didn't implement that to preserve the original style.Results
Before:
After:
