Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing WWW build #5826

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Fix failing WWW build #5826

merged 1 commit into from
Apr 4, 2024

Conversation

thegreatercurve
Copy link
Contributor

@thegreatercurve thegreatercurve commented Apr 4, 2024 •
edited

Fix failing WWW build by re-writing imports. This naturally aren't being tree-shaken since #5774

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 4, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 4, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 10:04am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 10:04am

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.77 KB (0%) 536 ms (0%) 201 ms (+40.77% 🔺) 736 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.01 KB (0%) 781 ms (0%) 478 ms (+6.54% 🔺) 1.3 s
packages/lexical-plain-text/dist/LexicalPlainText.js 38.98 KB (0%) 780 ms (0%) 407 ms (-0.1% 🔽) 1.2 s

@thegreatercurve thegreatercurve marked this pull request as ready for review April 4, 2024 10:11
@thegreatercurve thegreatercurve merged commit 6558e22 into main Apr 4, 2024
44 of 45 checks passed
tvongaza pushed a commit to aeon-health/lexical-old that referenced this pull request Apr 16, 2024
@thegreatercurve @tvongaza
Fix failing WWW build (facebook#5826)
72d1f38
@acywatson acywatson mentioned this pull request Apr 16, 2024
Merged
@dmitrymarokhonov dmitrymarokhonov mentioned this pull request May 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thegreatercurve @ivailop7 @facebook-github-bot