Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace async arrow with function #5870

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Replace async arrow with function #5870

merged 1 commit into from
Apr 11, 2024

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented Apr 11, 2024

Intern isn't happy with async arrows, we should follow up with a lint rule like we did with coalescent.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 11, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 11, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 0:23am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 0:23am

@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.95 KB (-0.02% 🔽) 539 ms (-0.02% 🔽) 12 ms (+18.16% 🔺) 551 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.37 KB (-0.01% 🔽) 788 ms (-0.01% 🔽) 34 ms (+11.56% 🔺) 822 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 39.34 KB (-0.02% 🔽) 787 ms (-0.02% 🔽) 31 ms (-17.73% 🔽) 818 ms

@zurfyx zurfyx merged commit f85a177 into main Apr 11, 2024
44 of 45 checks passed
@zurfyx zurfyx deleted the asyncbreak branch April 11, 2024 00:37
Sahejkm
Sahejkm reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@Sahejkm Sahejkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tvongaza pushed a commit to aeon-health/lexical-old that referenced this pull request Apr 16, 2024
@zurfyx @tvongaza
Replace async arrow with function (facebook#5870)
e33b11e
@acywatson acywatson mentioned this pull request Apr 16, 2024
Merged
@agriffis
Copy link
Contributor

What's intern?

@acywatson
Copy link
Contributor

What's intern?

ah it's just one of the environments Lexical runs in at Meta

@dmitrymarokhonov dmitrymarokhonov mentioned this pull request May 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sahejkm Sahejkm Sahejkm left review comments

@StyleT StyleT StyleT approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zurfyx @agriffis @acywatson @StyleT @Sahejkm @facebook-github-bot