Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@lexical/devtools): Extracted store/messaging implementation to the separate packages #5894

Merged
merged 1 commit into from
Apr 16, 2024
Merged

feat(@lexical/devtools): Extracted store/messaging implementation to the separate packages #5894

merged 1 commit into from
Apr 16, 2024

Conversation

StyleT
Copy link
Contributor

@StyleT StyleT commented Apr 15, 2024

Reasoning:

  • This adds strongly types RPC API for communication between extension surfaces (devtools / injected script / popup / background)
  • It moves store synchronization implementation to the unified transport layer (instead of relying on ad-hoc patches of the existing libraries)
  • We remove code that is unrelated to the Lexical DevTools from the repo to streamline communication stack development and keep examples/tests/infra outside of Lexical. So errors like this one: fix: Firefox XRay vision prevents window<->content script messaging serversideup/webext-bridge#83 can be fixed outside of Lexical.

@vercel Vercel
Copy link

vercel bot commented Apr 15, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 9:54pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 9:54pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2024
StyleT
StyleT commented Apr 15, 2024
View reviewed changes
.eslintrc.js
@@ -126,7 +126,6 @@ module.exports = {
rules: {
'accessor-pairs': OFF,

'brace-style': [ERROR, '1tbs'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier already enforces this. Removal of this rules prevents eslint and prettier from contradicting each other

@StyleT StyleT marked this pull request as ready for review April 16, 2024 00:32
fantactuka
fantactuka approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@fantactuka fantactuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice that you don't have to drag messaging methods through components

@StyleT StyleT merged commit 04546e1 into facebook:main Apr 16, 2024
45 checks passed
@acywatson acywatson mentioned this pull request Apr 16, 2024
Merged
@dmitrymarokhonov dmitrymarokhonov mentioned this pull request May 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantactuka fantactuka fantactuka approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StyleT @fantactuka @facebook-github-bot