docs: generate packages sidebar from filesystem & group @lexical/react #5931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etrepum
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
etrepum
force-pushed
the
docs-sidebars-gh-5916
branch
from
7d1eb74
to
da24bed
Compare
etrepum
force-pushed
the
docs-sidebars-gh-5916
branch
from
da24bed
to
c037516
Compare
etrepum
force-pushed
the
docs-sidebars-gh-5916
branch
from
c037516
to
93f6006
Compare
ivailop7
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare:
It took a few tries to get this right, but as far as I can tell it matches the expected output now without any unintended changes to the sidebar order or label names.
Something to explore as a separate docs follow-up would be to adjust the font size of the titles on the module pages. Since we are using fully qualified module names, a lot of them wrap at 3rem. That's an easy one for someone else :)
RE #5869 this helps fix up one of the many places that manual configuration is used, and can be done independently from #5876 since this is isolated to lexical-website.
Resolves #5916
Resolves #5913