Refactor table resizer rendering logic #5957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderReznik
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
AlexanderReznik
commented
Apr 24, 2024
| @@ -102,7 +83,7 @@ function TableCellResizer({editor}: {editor: LexicalEditor}): JSX.Element { | |||
| }); | |||
| return; | |||
| } | |||
|
|
|||
| updateIsMouseDown(isMouseDownOnEvent(event)); | |||
There was a problem hiding this comment.
This is a safety measure in case mouseup is not registered by the browser. I'm not sure if this can ever happen and I'll be happy to hear a second opinion, if this check is required
ivailop7
changed the title
|
@AlexanderReznik, in the preview here, I'm still getting the selection stuck |
This is not getting fixed in this pr, but I'll try to fix it later |
Ah, misunderstood what this was fixing. My fault. All good now. Thanks, Alex! |
ivailop7
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling table resizer when mouse button is pressed, instead of when the selection is of type
TableSelection.This makes ui slightly better in some cases:
Cursor doesn't change when starting the table selection
Cursor doesn't change when during range selection the cursor is over the table
