Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TreeView] Minor enhancement: Add option to obfuscate text in the TreeView plugin #5990

Merged
merged 1 commit into from
Apr 30, 2024
Merged

[TreeView] Minor enhancement: Add option to obfuscate text in the TreeView plugin #5990

merged 1 commit into from
Apr 30, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented Apr 30, 2024

[TreeView][Minor enhancement]

Description

Add option to obfuscate the text to be used for Logging tree view for debugging

Test plan

Screenshot 2024-04-30 at 5 40 42 PM

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 30, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview Apr 30, 2024 9:51am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 9:51am

@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.69 KB (0%) 474 ms (0%) 294 ms (+432.52% 🔺) 768 ms
packages/lexical-rich-text/dist/LexicalRichText.js 33.91 KB (0%) 679 ms (0%) 453 ms (+199.81% 🔺) 1.2 s
packages/lexical-plain-text/dist/LexicalPlainText.js 33.91 KB (0%) 679 ms (0%) 465 ms (+260.14% 🔺) 1.2 s

@potatowagon potatowagon changed the title Add option to obfuscate text in the TreeView plugin [TreeView] Minor enhancement: Add option to obfuscate text in the TreeView plugin Apr 30, 2024
potatowagon
potatowagon approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@potatowagon potatowagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Sahejkm Sahejkm merged commit f596b1b into main Apr 30, 2024
46 checks passed
@Sahejkm Sahejkm deleted the obfuscate_text_tree branch May 7, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potatowagon potatowagon potatowagon approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sahejkm @potatowagon @facebook-github-bot