fix(build): fix build-www rewriteImports to always rewrite flow modules #5995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etrepum
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
etrepum
commented
Apr 30, 2024
| // Let the transform know we actually did something. | ||
| // Could not figure out the right way to update the | ||
| // docblock without an in-place update | ||
| context.addLeadingComments(node, ''); |
There was a problem hiding this comment.
I don't like this but hermes doesn't really have documentation and I was getting errors with other incantations that replaced or updated the program node
|
let's try it! |
acywatson
approved these changes
Apr 30, 2024
etrepum
added a commit
to etrepum/lexical
that referenced
this pull request
May 1, 2024
acywatson
pushed a commit
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rewriteImports regression caused some flow modules not to get rewritten. Working theory is that the in-place update only had an effect if a module was also rewritten, and some modules do not have dependencies (such as packages/lexical/dist/Lexical.js.flow)
Test plan
Before
build-www outputs some flow modules in dist without rewriting their comments
After
build-www outputs all flow modules in dist with rewritten comments