Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-playground][lexical-text] Bug Fix: handling hashtag following multiple invalid matches #6053

Merged
merged 2 commits into from
May 8, 2024
Merged

[lexical-playground][lexical-text] Bug Fix: handling hashtag following multiple invalid matches #6053

merged 2 commits into from
May 8, 2024

Conversation

2wheeh
Copy link
Contributor

@2wheeh 2wheeh commented May 7, 2024 •
edited

Description

prevMatchLengthToSkip is introduced in #6045 to handle invalid previous match.
So I believe we should let prevMatchLengthToSkip do its job instead of early returning $textNodeTransform when the next match is followed.

Test plan

Before

2024-05-08.7.14.46.mov

After

2024-05-08.6.54.56.mov

@vercel Vercel
Copy link

vercel bot commented May 7, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 10:29pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 10:29pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 7, 2024
Sahejkm
Sahejkm approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@Sahejkm Sahejkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks for adding this so quick, i was also looking into fixing this test case next.

@StyleT StyleT merged commit 89a9701 into facebook:main May 8, 2024
45 checks passed
@2wheeh 2wheeh deleted the mulitple-invalid-hashtags branch May 8, 2024 02:03
@2wheeh 2wheeh mentioned this pull request May 8, 2024
Merged
Sahejkm added a commit that referenced this pull request May 8, 2024
@Sahejkm
Revert "fix(@lexical/text): for handling hashtag following multiple i…
c91834d 
…nvalid matches (#6053)"

This reverts commit 89a9701.
@Sahejkm Sahejkm mentioned this pull request May 8, 2024
Merged
Sahejkm added a commit that referenced this pull request May 8, 2024
@Sahejkm
Revert #6053 first till proper fix is shipped in #6056 (#6058)
bddd362
@Sahejkm Sahejkm mentioned this pull request May 9, 2024
Merged
Sahejkm added a commit that referenced this pull request May 9, 2024
@Sahejkm
[Leixcal][Hashtag] Fix prevSibling not getting updated after replacem…
55a9c94 
…ent of match as followup #6053 (#6067)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StyleT StyleT StyleT approved these changes

@Sahejkm Sahejkm Sahejkm approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@2wheeh @StyleT @Sahejkm @facebook-github-bot