[lexical-devtools] Feature: Reflect picker state on inspector button ui #6077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2wheeh
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
2wheeh
changed the title
StyleT
requested changes
May 13, 2024
There was a problem hiding this comment.
Hi! Thanks for this contribution!
Do you think it's possible to implement this via ExtensionStore instead of a bit quirky way when we try to keep sync via pending promise?
Also if done via store - we can sync that state to popup window as well easy peasy, while current approach makes it impossible
|
@StyleT Thanks ! I reverted and changed to utilize store. Please check the last commit |
StyleT
force-pushed
the
picker-state-on-ui
branch
from
1a1da5e
to
5182de2
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EditorInspectorButtonreflects pickerActive state on UI.Closes: #6068
Test plan
Before
2024-05-10.6.36.16.mov
After
2024-05-10.6.33.59.mov