Skip to content
This repository
Browse code

Remove hardcoded maven settings.xml ref

Summary:
This stops ant build from succeeding since settings.xml not bundled with
linkbnech.

Proxy settings can be configured globally e.g. with $HOME/.ant/settings.xml

Test Plan: ant succeeds in compiling

Reviewers: emayanke, dhruba

Reviewed By: emayanke

Differential Revision: https://reviews.facebook.net/D8295
  • Loading branch information...
commit 24a48fb97645da689c6a78b4ce09ae7c2fb16c58 1 parent 7481a67
Tim Armstrong authored January 31, 2013

Showing 2 changed files with 6 additions and 2 deletions. Show diff stats Hide diff stats

  1. 6  README.md
  2. 2  build.xml
6  README.md
Source Rendered
@@ -90,7 +90,7 @@ or Mac OS X.
90 90
       Java runtime version.  You will also need a Java JDK to compile from source.
91 91
 
92 92
 **Ant**: To build LinkBench, you will need the Apache Ant build tool. If
93  
-    you do not have it already, it is available from http://ant.apache.org
  93
+    you do not have it already, it is available from http://ant.apache.org .
94 94
 
95 95
 **MySQL Connector**:  To benchmark MySQL with LinkBench, you need MySQL
96 96
     Connector/J, A version of the MySQL connector is bundled with
@@ -116,6 +116,10 @@ If the build is successful, you should get a message like this at the end of the
116 116
     BUILD SUCCESSFUL
117 117
     Total time: 3 seconds
118 118
 
  119
+If the build fails while downloading required files, you may need to configure Maven,
  120
+for example to use a proxy.  Example Maven proxy configuration is shown here:
  121
+http://maven.apache.org/guides/mini/guide-proxies.html
  122
+
119 123
 Now you can run the LinkBench command line tool:
120 124
 
121 125
     ./bin/linkbench
2  build.xml
@@ -135,7 +135,7 @@
135 135
     <artifact:remoteRepository id="fbnexus" url="${mvn.fb.repo}"/>
136 136
 
137 137
     <!-- Download the dependencies -->
138  
-    <artifact:dependencies filesetId="build-dependency-jars" settingsFile="${basedir}/settings.xml">
  138
+    <artifact:dependencies filesetId="build-dependency-jars">
139 139
       <pom file="pom.xml"/>
140 140
     </artifact:dependencies>
141 141
 

0 notes on commit 24a48fb

Please sign in to comment.
Something went wrong with that request. Please try again.