Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: Pull Request resolved: #992 I noticed on GitHub that a bunch of tests are now failing on master. The same is true in Sandcastle: https://www.internalfb.com/sandcastle/workflow/382805968329783817/artifact/actionlog.382805968392335671.stdout.1 ``` 7 TESTS FAILED ✗ fbsource//fbandroid/javatests/instagram/features/clips/viewer/adapter/organic/mediainfo/authorinfo:authorinfo - test ClipsAuthorInfoComponent is rendered for Clips items (instagram.features.clips.viewer.adapter.organic.mediainfo.authorinfo.ClipsAuthorInfoComponentTest) ✗ fbsource//fbandroid/libraries/components/litho-it/src/test/java/com/facebook/litho:litho - testIncrementalMountTriggeredAfterUnmountAllWithSameDimensions[IncrementalMountConfiguration:][api=33][looperMode=LEGACY] (com.facebook.litho.LithoViewMountTest) ✗ fbsource//fbandroid/libraries/components/litho-it/src/test/java/com/facebook/litho:litho - testSetComponentTwiceWithResetAndAttachRequestsLayout[IncrementalMountConfiguration:][api=33][looperMode=LEGACY] (com.facebook.litho.LithoViewMountTest) ✗ fbsource//fbandroid/libraries/components/litho-it/src/test/java/com/facebook/litho:litho - testSetSameSizeComponentAndAttachRequestsLayout[IncrementalMountConfiguration:][api=33][looperMode=LEGACY] (com.facebook.litho.LithoViewMountTest) ✗ fbsource//fbandroid/libraries/components/litho-it/src/test/java/com/facebook/litho:litho - testReAttachRequestsLayout[IncrementalMountConfiguration:][api=33][looperMode=LEGACY] (com.facebook.litho.LithoViewMountTest) ✗ fbsource//fbandroid/libraries/components/litho-it/src/test/java/com/facebook/litho:litho - measureWithLayoutParams[IncrementalMountConfiguration:][api=33][looperMode=LEGACY] (com.facebook.litho.LithoViewTest) ✗ fbsource//fbandroid/javatests/com/oculus/socialplatform/receivers:receivers - main ``` Based on adityasharat's recommendation, I first tried to change the LooperMode which sadly didn't change the outcome, and then disabled the tests based on a config flag. Reviewed By: adityasharat Differential Revision: D58818690 fbshipit-source-id: dc738bc23f431f74cd34b637571215db575ce686
- Loading branch information