Makes keeping node and results saner

Summary: Makes keeping node and results saner Reviewed By: pentiumao Differential Revision: D45393246 fbshipit-source-id: 26f892d5848144890d7f1dcafa730c584f86277b
facebook · Apr 28, 2023 · 576f5ce · 576f5ce
1 parent 1cde080
commit 576f5ce
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 11 deletions.
diff --git a/litho-core/src/main/java/com/facebook/litho/LayoutState.java b/litho-core/src/main/java/com/facebook/litho/LayoutState.java
@@ -1226,17 +1226,29 @@ static void setSizeAfterMeasureAndCollectResults(
       ComponentsSystrace.endSection();
     }
 
-    final LithoNode forSaving = layoutState.mRoot;
-    if (!c.isReconciliationEnabled()
-        && !ComponentsConfiguration.isDebugModeEnabled
-        && !ComponentsConfiguration.isEndToEndTestRun
-        && !ComponentsConfiguration.keepLithoNodes) {
-      layoutState.mRoot = null;
-      layoutState.mLayoutResult = null;
+    final LithoNode nodeForSaving = layoutState.mRoot;
+    final LithoLayoutResult layoutResultForSaving = layoutState.mLayoutResult;
+
+    // clean it up for sanity
+    layoutState.mRoot = null;
+    layoutState.mLayoutResult = null;
+
+    // enabled for debugging and end to end tests
+    if (ComponentsConfiguration.isDebugModeEnabled || ComponentsConfiguration.isEndToEndTestRun) {
+      layoutState.mRoot = nodeForSaving;
+      layoutState.mLayoutResult = layoutResultForSaving;
+      return;
+    }
+
+    // only keep the node if reconciliation is enabled for legacy render
+    if (c.isReconciliationEnabled()
+        && c.mLithoConfiguration.mComponentsConfiguration.isLegacyRenderEnabled()) {
+      layoutState.mRoot = nodeForSaving;
     }
 
-    if (ComponentsConfiguration.keepLithoNodes) {
-      layoutState.mRoot = forSaving;
+    // override used by analytics teams
+    if (ComponentsConfiguration.keepLayoutResults) {
+      layoutState.mLayoutResult = layoutResultForSaving;
     }
   }
 

diff --git a/litho-core/src/main/java/com/facebook/litho/config/ComponentsConfiguration.java b/litho-core/src/main/java/com/facebook/litho/config/ComponentsConfiguration.java
@@ -161,8 +161,8 @@ public static boolean isRenderInfoDebuggingEnabled() {
   /** When {@code true}, disables incremental mount globally. */
   public static boolean isIncrementalMountGloballyDisabled = false;
 
-  /** Keeps the litho node tree in the LayoutState. This will increase memory use. */
-  public static boolean keepLithoNodes = false;
+  /** Keeps the litho layout result tree in the LayoutState. This will increase memory use. */
+  public static boolean keepLayoutResults = false;
 
   /**
    * Used by LithoViews to determine whether or not to self-manage the view-port changes, rather