Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .component(Component.Builder) variant to ComponentInfo.Builder #89

Closed
lucasr opened this issue Apr 17, 2017 · 4 comments
Closed

Add .component(Component.Builder) variant to ComponentInfo.Builder #89

lucasr opened this issue Apr 17, 2017 · 4 comments

Comments

@lucasr
Copy link
Contributor

lucasr commented Apr 17, 2017

So that we don't force users to explicitly call build() when updating a RecyclerBinder.

Point of contact: @pasqualeanatriello

@narayanacharya6
Copy link

Hey @pasqualeanatriello would like to pick this up if its up for grabs? PS: New guy here.

@pasqualeanatriello
Copy link
Contributor

pasqualeanatriello commented Mar 25, 2018 via email

@pavlospt
Copy link
Contributor

ComponentRenderInfo includes a component() method. https://github.com/facebook/litho/blob/66d10f00bc41107656e41810cc6b15e7ebabdef1/litho-widget/src/main/java/com/facebook/litho/widget/ComponentRenderInfo.java I think I can relatively easy add an overloaded one for ComponentRenderInfo.Builder if it still up for implementation!

@passy
Copy link
Member

passy commented Apr 24, 2018

Yeah, go for it. :)

pavlospt added a commit to pavlospt/litho that referenced this issue Apr 24, 2018
* Adds method in ComponentRenderInfo.Builder that accepts a Component.Builder
Closes facebook#89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants