Enable LTI in xplat/js/tools

Reviewed By: mvitousek

Differential Revision: D41773350

fbshipit-source-id: 1785fb753f01054a5c3f00c5eda9d5beae142b86

.flowconfig

@@ -21,6 +21,8 @@ suppress_type=$FlowFixMeProps
 suppress_type=$FlowFixMeState
 suppress_type=$FlowFixMeEmpty
 
+inference_mode=experimental.lti
+
 [lints]
 sketchy-null-number=warn
 sketchy-null-mixed=warn

flow-typed/Promise.js

@@ -15,23 +15,23 @@
 // These annotations are copy/pasted from the built-in Flow definitions and
 // tweaked so that then() and catch() accept `null` arguments, that they
 // rightfully do. This should probably be changed in the core lib eventually.
-declare class Promise<+R> {
+declare class Promise<+R = mixed> {
   constructor(
     callback: (
       resolve: (result?: Promise<R> | R) => void,
       reject: (error?: any) => void,
     ) => mixed,
   ): void;
 
-  then<U>(
+  then<U = mixed>(
     onFulfill?: ?(value: R) => Promise<U> | ?U,
     onReject?: ?(error: any) => Promise<U> | ?U,
   ): Promise<U>;
 
-  catch<U>(onReject?: (error: any) => ?Promise<U> | U): Promise<U>;
+  catch<U = mixed>(onReject?: (error: any) => ?Promise<U> | U): Promise<U>;
 
-  static resolve<T>(object?: Promise<T> | T): Promise<T>;
-  static reject<T>(error?: mixed): Promise<T>;
+  static resolve<T = mixed>(object?: Promise<T> | T): Promise<T>;
+  static reject<T = mixed>(error?: mixed): Promise<T>;
 
   static all<T: Iterable<mixed>>(
     promises: T,

flow-typed/jest.js

@@ -11,7 +11,10 @@
 
 // Copied from https://raw.githubusercontent.com/flow-typed/flow-typed/master/definitions/npm/jest_v26.x.x/flow_v0.134.x-/jest_v26.x.x.js
 
-type JestMockFn<TArguments: $ReadOnlyArray<*>, TReturn> = {
+type JestMockFn<
+  TArguments: $ReadOnlyArray<any> = $ReadOnlyArray<any>,
+  TReturn = any,
+> = {
   (...args: TArguments): TReturn,
   /**
    * An object for introspecting mock calls
@@ -834,7 +837,7 @@ type JestObjectType = {
    * Returns a new, unused mock function. Optionally takes a mock
    * implementation.
    */
-  fn<TArguments: $ReadOnlyArray<*>, TReturn>(
+  fn<TArguments: $ReadOnlyArray<any> = $ReadOnlyArray<any>, TReturn = any>(
     implementation?: (...args: TArguments) => TReturn,
   ): JestMockFn<TArguments, TReturn>,
   /**

packages/metro-file-map/src/watchers/__tests__/integration-test.js

@@ -110,7 +110,11 @@ describe.each(Object.keys(WATCHERS))(
 
       nextEvent = afterFn =>
         Promise.all([
-          new Promise((resolve, reject) => {
+          new Promise<{
+            eventType: string,
+            metadata?: ChangeEventMetadata,
+            path: string,
+          }>((resolve, reject) => {
             const listener = (
               eventType: string,
               path: string,
@@ -139,6 +143,7 @@ describe.each(Object.keys(WATCHERS))(
           rejectUnexpected: false,
         });
 
+      // $FlowFixMe[incompatible-use]
       allEvents = (afterFn, expectedEvents, {rejectUnexpected = true} = {}) =>
         Promise.all([
           new Promise(async (resolve, reject) => {

packages/metro-source-map/src/Generator.js

@@ -179,6 +179,7 @@ class Generator {
       version: 3,
       file,
       sources: this.sources.slice(),
+      // $FlowFixMe[exponential-spread]
       ...content,
       /* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment suppresses an
        * error found when Flow v0.111 was deployed. To see the error, delete

packages/metro-symbolicate/src/ChromeHeapSnapshot.js

@@ -254,9 +254,9 @@ class ChromeHeapSnapshotRecordAccessor {
       );
       if (Array.isArray(recordTypes)) {
         this._fieldToType = new Map<string, ChromeHeapSnapshotFieldType>(
+          // $FlowIssue[incompatible-call] Object.entries is incompletely typed
           Object.entries(recordTypes).map(([offsetStr, type]) => [
             recordFields[Number(offsetStr)],
-            // $FlowIssue[incompatible-call] Object.entries is incompletely typed
             type,
           ]),
         );

packages/metro-transform-plugins/src/import-export-plugin.js

@@ -522,6 +522,7 @@ function importExportPlugin({types: t}: {types: Types, ...}): PluginObj<State> {
           state.exportAll.forEach(
             (e: {file: string, loc: ?BabelSourceLocation, ...}) => {
               body.push(
+                // $FlowFixMe[incompatible-call]
                 ...withLocation(
                   exportAllTemplate({
                     FILE: resolvePath(

packages/metro-transform-plugins/src/inline-plugin.js

@@ -61,13 +61,16 @@ function inlinePlugin(
     options.requireName || 'require',
   );
 
-  const isGlobal = (binding: ?Binding): boolean %checks => !binding;
+  function isGlobal(binding: ?Binding): boolean %checks {
+    return !binding;
+  }
 
   const isFlowDeclared = (binding: Binding) =>
     t.isDeclareVariable(binding.path);
 
-  const isGlobalOrFlowDeclared = (binding: ?Binding): boolean %checks =>
-    isGlobal(binding) || isFlowDeclared(binding);
+  function isGlobalOrFlowDeclared(binding: ?Binding): boolean %checks {
+    return isGlobal(binding) || isFlowDeclared(binding);
+  }
 
   const isLeftHandSideOfAssignmentExpression = (
     node: Node,

packages/metro-transform-plugins/src/normalizePseudoGlobals.js

@@ -45,8 +45,8 @@ function normalizePseudoglobals(
       }
 
       const pseudoglobals: Array<string> = params
-        // $FlowFixMe Flow error uncovered by typing Babel more strictly
         .map(path => path.node.name)
+        // $FlowFixMe[incompatible-call] Flow error uncovered by typing Babel more strictly
         .filter(name => !reservedNames.has(name));
 
       const usedShortNames = new Set<string>();

packages/metro-transform-plugins/src/utils/createInlinePlatformChecks.js

@@ -116,7 +116,9 @@ function createInlinePlatformChecks(
       isWrappedModule,
     );
 
-  const isGlobal = (binding: void | $FlowFixMe): boolean %checks => !binding;
+  function isGlobal(binding: mixed): boolean %checks {
+    return !binding;
+  }
 
   const isRequireCall = (
     node: BabelNodeExpression,

packages/metro/src/DeltaBundler/Transformer.js

@@ -135,7 +135,10 @@ class Transformer {
 
     // A valid result from the cache is used directly; otherwise we call into
     // the transformer to computed the corresponding result.
-    const data = result
+    const data: $ReadOnly<{
+      result: TransformResult<>,
+      sha1: string,
+    }> = result
       ? {result, sha1}
       : await this._workerFarm.transform(
           localPath,

packages/metro/src/HmrServer.js

@@ -18,6 +18,7 @@ import type {
   HmrMessage,
   HmrUpdateMessage,
 } from 'metro-runtime/src/modules/types.flow';
+import type {UrlWithParsedQuery} from 'url';
 
 const hmrJSBundle = require('./DeltaBundler/Serializers/hmrJSBundle');
 const GraphNotFoundError = require('./IncrementalBundler/GraphNotFoundError');
@@ -34,8 +35,7 @@ const {
 const nullthrows = require('nullthrows');
 const url = require('url');
 
-type $ReturnType<F> = $Call<<A, R>((...A) => R) => R, F>;
-export type EntryPointURL = $ReturnType<typeof url.parse>;
+export type EntryPointURL = UrlWithParsedQuery;
 
 export type Client = {
   optedIntoHMR: boolean,
@@ -145,7 +145,7 @@ class HmrServer<TClient: Client> {
     const {graph, id} = await revPromise;
     client.revisionIds.push(id);
 
-    let clientGroup = this._clientGroups.get(id);
+    let clientGroup: ?ClientGroup = this._clientGroups.get(id);
     if (clientGroup != null) {
       clientGroup.clients.add(client);
     } else {

packages/metro/src/lib/getAppendScripts.js

@@ -37,7 +37,7 @@ function getAppendScripts<T: number | string>(
   modules: $ReadOnlyArray<Module<>>,
   options: Options<T>,
 ): $ReadOnlyArray<Module<>> {
-  const output = [];
+  const output: Array<Module<>> = [];
 
   if (options.runModule) {
     const paths = [...options.runBeforeMainModule, entryPoint];