Skip to content

Commit

Permalink
Increase minimum Node version from 14 to 16
Browse files Browse the repository at this point in the history
Summary:
Following the same change in React Native for the upcoming 0.72 release ([facebook/react-native#36217](facebook/react-native#36217)), increase minimum supported Node.js version for all Metro packages to `>=16`.

Changelog: **[Breaking]** Increase minimum Node version from 14 to 16

Reviewed By: hoxyq

Differential Revision: D43464209

fbshipit-source-id: f0f573211838cbe5f79bc16fa005b86c180b41c4
  • Loading branch information
huntie authored and facebook-github-bot committed Feb 23, 2023
1 parent 77f445f commit e5950ae
Show file tree
Hide file tree
Showing 26 changed files with 28 additions and 29 deletions.
7 changes: 3 additions & 4 deletions .circleci/config.yml
Expand Up @@ -10,8 +10,7 @@ references:
# For stability, Node.js versions we run against in CI are defined explicitly
# (the "lts" alias may bring in a future version before we support it)
node_supported_lts_versions: &node_supported_lts_versions
- &node_min_supported_version "14.17"
- "16.18"
- &node_min_supported_version "16.18"
- "18.12"
node_lts_image: &node_lts_image cimg/node:18.12

Expand Down Expand Up @@ -76,7 +75,7 @@ jobs:
name: Upload coverage results
command: ./codecov -t ${CODECOV_TOKEN} -f ./coverage/coverage-final.json

test-linux:
test:
<<: *secure_unset_publish_token
parameters:
node-version:
Expand Down Expand Up @@ -118,7 +117,7 @@ workflows:
jobs:
- run-js-checks
- test-with-coverage
- test-linux:
- test:
matrix:
parameters:
node-version: *node_supported_lts_versions
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -88,6 +88,6 @@
"license": "MIT",
"dependencies": {},
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/buck-worker-tool/package.json
Expand Up @@ -20,6 +20,6 @@
"cleanup-release": "test ! -e build && mv src build && mv src.real src"
},
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-babel-register/package.json
Expand Up @@ -25,6 +25,6 @@
},
"license": "MIT",
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-babel-transformer/package.json
Expand Up @@ -23,6 +23,6 @@
"nullthrows": "^1.1.1"
},
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-cache-key/package.json
Expand Up @@ -16,6 +16,6 @@
"metro-memory-fs": "0.75.1"
},
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-cache/package.json
Expand Up @@ -20,6 +20,6 @@
},
"license": "MIT",
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-config/package.json
Expand Up @@ -25,6 +25,6 @@
"strip-ansi": "^6.0.0"
},
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-core/package.json
Expand Up @@ -17,6 +17,6 @@
},
"license": "MIT",
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-file-map/package.json
Expand Up @@ -34,6 +34,6 @@
"fsevents": "^2.3.2"
},
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-hermes-compiler/package.json
Expand Up @@ -13,6 +13,6 @@
},
"license": "MIT",
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-inspector-proxy/package.json
Expand Up @@ -24,6 +24,6 @@
"node-fetch": "^2.2.0"
},
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-memory-fs/package.json
Expand Up @@ -13,6 +13,6 @@
},
"license": "MIT",
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-minify-terser/package.json
Expand Up @@ -16,6 +16,6 @@
"terser": "^5.15.0"
},
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-minify-uglify/package.json
Expand Up @@ -16,6 +16,6 @@
"uglify-es": "^3.1.9"
},
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-react-native-babel-preset/package.json
Expand Up @@ -62,6 +62,6 @@
"@babel/core": "*"
},
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-react-native-babel-transformer/package.json
Expand Up @@ -30,6 +30,6 @@
"@babel/core": "*"
},
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-react-native-interop-tools/package.json
Expand Up @@ -19,6 +19,6 @@
},
"license": "MIT",
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-resolver/package.json
Expand Up @@ -17,6 +17,6 @@
},
"license": "MIT",
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-runtime/package.json
Expand Up @@ -22,6 +22,6 @@
"react-test-renderer": "^18.2.0"
},
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-source-map/package.json
Expand Up @@ -28,6 +28,6 @@
"uglify-es": "^3.1.9"
},
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-symbolicate/package.json
Expand Up @@ -25,6 +25,6 @@
"vlq": "^1.0.0"
},
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-transform-plugins/package.json
Expand Up @@ -27,6 +27,6 @@
"metro": "0.75.1"
},
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro-transform-worker/package.json
Expand Up @@ -33,6 +33,6 @@
"metro-react-native-babel-transformer": "0.75.1"
},
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/metro/package.json
Expand Up @@ -80,6 +80,6 @@
},
"license": "MIT",
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}
2 changes: 1 addition & 1 deletion packages/ob1/package.json
Expand Up @@ -17,6 +17,6 @@
"license": "MIT",
"dependencies": {},
"engines": {
"node": ">=14.17.0"
"node": ">=16"
}
}

0 comments on commit e5950ae

Please sign in to comment.