pass custom customTransformOptions and customResolverOptions to bundle_build_started log event #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_build_started log event
facebook-github-bot
added
CLA Signed
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Looks good to me, but there's a Flow error in |
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
We always used to, but this was turned off on CircleCI for PRs from forks, not sure when/why - I've just re-enabled it. |
|
Lint error now is due to an internal callsite that needs updating - I'll take care of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We use
customTransformOptionsin Expo CLI to inform Metro that we're bundling for a Node.js environment (in addition to theplatform=web), but the logger has no way of indicating to the user that a bundle is Server-specific. This change would enable us to refine the bundling message based on the additional criteria. We can do this if we skip over the server (exports/builds) but it'd be good to have parity. Example usage, corresponding output.Test plan