Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(metro-resolver): more descriptive assertions in should resolve exports target directly tests #1240

Closed
wants to merge 3 commits into from
Closed

refactor(metro-resolver): more descriptive assertions in should resolve exports target directly tests #1240

wants to merge 3 commits into from

Conversation

jbroma
Copy link
Contributor

@jbroma jbroma commented Mar 21, 2024 •
edited

Summary

This PR adds comments to assertions in tests that check that neither sourceExts or platformExts are expanded when matching exports target directly, which was suggested inside of #1236 by @huntie. The assertions rely on using [nonstrict] fallback mechanism as there is no other way to test this functionality right now because strict mode is not implemented.

Changelog: [Internal] Refactor Package Exports sourceExts and platformExts tests that rely on fallback

Test plan

  • - all tests pass

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Mar 21, 2024
huntie
huntie reviewed Mar 22, 2024
View reviewed changes
Copy link
Member

@huntie huntie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this 💯 I was drafting the same changes locally 😄. However can we make this even more focused/strict — see inline feedback.

packages/metro-resolver/src/__tests__/package-exports-test.js Outdated Show resolved Hide resolved
packages/metro-resolver/src/__tests__/package-exports-test.js Outdated Show resolved Hide resolved
@jbroma jbroma changed the title fix(metro-resolver): improve assertions in should resolve exports target directly tests fix(metro-resolver): more descriptive assertions in should resolve exports target directly tests Mar 27, 2024
@jbroma
Copy link
Contributor Author

jbroma commented Mar 27, 2024

@huntie applied your suggestions, revised PR description & added changelog

@jbroma jbroma changed the title fix(metro-resolver): more descriptive assertions in should resolve exports target directly tests refactor(metro-resolver): more descriptive assertions in should resolve exports target directly tests Mar 27, 2024
@facebook-github-bot
Copy link
Contributor

@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@huntie merged this pull request in 3606983.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huntie huntie huntie approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbroma @facebook-github-bot @huntie