[metro-babel-register] Ignore babel.config.js files in addition to .babelrc #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abelrc This adds support for projects using `metro-babel-register` with Babel 7's babel.config.js files. The `metro-babel-register` package is designed to apply a static, hardcoded list of Babel plugins. It intentionally ignores .babelrc files by setting `babelrc: false`. Babel 7 added a new configuration file called babel.config.js, with similar but slightly different loading semantics. To disable babel.config.js lookup, there is a new option called `configFile` instead of `babelrc`. See https://babeljs.io/docs/en/next/config-files#project-wide-configuration. Fixes facebook/react-native#21052 Test plan: In a React Native project with babel.config.js and an error about `regeneratorRuntime` missing, said error goes away with this `metro-babel-register` patch.
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
=======================================
Coverage 85.75% 85.75%
=======================================
Files 144 144
Lines 4548 4548
Branches 712 712
=======================================
Hits 3900 3900
Misses 580 580
Partials 68 68Continue to review full report at Codecov.
|
rafeca
approved these changes
Oct 2, 2018
There was a problem hiding this comment.
rafeca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Ragnar-H
added a commit
to Ragnar-H/metro-babel-register
that referenced
this pull request
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for projects using
metro-babel-registerwith Babel 7's babel.config.js files. Themetro-babel-registerpackage is designed to apply a static, hardcoded list of Babel plugins. It intentionally ignores .babelrc files by settingbabelrc: false.Babel 7 added a new configuration file called babel.config.js, with similar but slightly different loading semantics. To disable babel.config.js lookup, there is a new option called
configFileinstead ofbabelrc. See https://babeljs.io/docs/en/next/config-files#project-wide-configuration.Fixes facebook/react-native#21052
Test plan
In a React Native project with babel.config.js and an error about
regeneratorRuntimemissing when starting the CLI, said error goes away with thismetro-babel-registerpatch.