Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle circular dependency upon dependency removal #506

Closed
wants to merge 7 commits into from
Closed

Handle circular dependency upon dependency removal #506

wants to merge 7 commits into from

Commits on Jan 3, 2020

  1. When removing a dependency, we don't abort removal only because its 

    inverseDependencies is not empty. Rather, we recursively check the
inverseDependencies to see if it eventually only points to the removed
module. If this is the case, then we need to proceed removing dependency
instead of returning early.
    @raejin
    raejin committed Jan 3, 2020
    Copy the full SHA
    ae87904 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2020

  1. address comment

    @raejin
    raejin committed Jan 6, 2020
    Copy the full SHA
    33985ad View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2020

  1. Due to performance bug with the previous implementation, I implemented a 

    memoized solution to short circuit any situation when a module does not
need further DFS.
    @raejin
    raejin committed Jan 16, 2020
    Copy the full SHA
    d194e41 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2020

  1. Remove not needed async/await

    @raejin
    raejin committed Jan 17, 2020
    Copy the full SHA
    b836f22 View commit details
    Browse the repository at this point in the history

  2. Update traverseDependencies-test.js

    @cpojer
    cpojer committed Jan 17, 2020
    Copy the full SHA
    21e0117 View commit details
    Browse the repository at this point in the history

  3. Update traverseDependencies.js

    @cpojer
    cpojer committed Jan 17, 2020
    Copy the full SHA
    a421882 View commit details
    Browse the repository at this point in the history

  4. Update traverseDependencies.js

    @cpojer
    cpojer committed Jan 17, 2020
    Copy the full SHA
    9193ee1 View commit details
    Browse the repository at this point in the history