-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the SegmentedComponentIOS
away from React Native Core
#776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
labels
Feb 18, 2022
This pull request was exported from Phabricator. Differential Revision: D34304255 |
Summary: This Diff moves the `SegmentedComponentIOS` away from the core of React Native to move forward with the Lean Core effort ## Changelog [General][Removed] - This diff removes the `SegmentedControlIOS` export from React Native. Internally, we are requiring `SegmentedControlIOS` directly now and externally people will have to use the community maintained module (https://github.com/react-native-segmented-control). Differential Revision: D34304255 fbshipit-source-id: 08521822268187d9f817aa77b210402ab2348730
This pull request was exported from Phabricator. Differential Revision: D34304255 |
cipolleschi
force-pushed
the
export-D34304255
branch
from
February 18, 2022 11:04
bbf6e43
to
9bec4bd
Compare
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Feb 18, 2022
…k#776) Summary: Pull Request resolved: facebook/metro#776 This Diff moves the `SegmentedComponentIOS` away from the core of React Native to move forward with the Lean Core effort ## Changelog [General][Removed] - This diff removes the `SegmentedControlIOS` export from React Native. Internally, we are requiring `SegmentedControlIOS` directly now and externally people will have to use the community maintained module (https://github.com/react-native-segmented-control). Differential Revision: D34304255 fbshipit-source-id: 8688b75a7c1300359470df36072e99e5c06c2bef
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Feb 21, 2022
Summary: Pull Request resolved: #33140 Pull Request resolved: facebook/metro#776 This Diff moves the `SegmentedComponentIOS` away from the core of React Native to move forward with the Lean Core effort ## Changelog [General][Removed] - This diff removes the `SegmentedControlIOS` export from React Native. Internally, we are requiring `SegmentedControlIOS` directly now and externally people will have to use the community maintained module (https://github.com/react-native-segmented-control). Reviewed By: cortinico Differential Revision: D34304255 fbshipit-source-id: d4e2b0bda56708769603be6f164e6bf89997fd93
nevilm-lt
pushed a commit
to nevilm-lt/metro
that referenced
this pull request
Mar 14, 2022
Summary: Pull Request resolved: facebook/react-native#33140 Pull Request resolved: facebook#776 This Diff moves the `SegmentedComponentIOS` away from the core of React Native to move forward with the Lean Core effort ## Changelog [General][Removed] - This diff removes the `SegmentedControlIOS` export from React Native. Internally, we are requiring `SegmentedControlIOS` directly now and externally people will have to use the community maintained module (https://github.com/react-native-segmented-control). Reviewed By: cortinico Differential Revision: D34304255 fbshipit-source-id: d4e2b0bda56708769603be6f164e6bf89997fd93
nevilm-lt
pushed a commit
to nevilm-lt/metro
that referenced
this pull request
Apr 21, 2022
Summary: Pull Request resolved: facebook/react-native#33140 Pull Request resolved: facebook#776 This Diff moves the `SegmentedComponentIOS` away from the core of React Native to move forward with the Lean Core effort ## Changelog [General][Removed] - This diff removes the `SegmentedControlIOS` export from React Native. Internally, we are requiring `SegmentedControlIOS` directly now and externally people will have to use the community maintained module (https://github.com/react-native-segmented-control). Reviewed By: cortinico Differential Revision: D34304255 fbshipit-source-id: d4e2b0bda56708769603be6f164e6bf89997fd93
nevilm-lt
pushed a commit
to nevilm-lt/metro
that referenced
this pull request
Apr 22, 2022
Summary: Pull Request resolved: facebook/react-native#33140 Pull Request resolved: facebook#776 This Diff moves the `SegmentedComponentIOS` away from the core of React Native to move forward with the Lean Core effort ## Changelog [General][Removed] - This diff removes the `SegmentedControlIOS` export from React Native. Internally, we are requiring `SegmentedControlIOS` directly now and externally people will have to use the community maintained module (https://github.com/react-native-segmented-control). Reviewed By: cortinico Differential Revision: D34304255 fbshipit-source-id: d4e2b0bda56708769603be6f164e6bf89997fd93
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
…k#33140) Summary: Pull Request resolved: facebook#33140 Pull Request resolved: facebook/metro#776 This Diff moves the `SegmentedComponentIOS` away from the core of React Native to move forward with the Lean Core effort ## Changelog [General][Removed] - This diff removes the `SegmentedControlIOS` export from React Native. Internally, we are requiring `SegmentedControlIOS` directly now and externally people will have to use the community maintained module (https://github.com/react-native-segmented-control). Reviewed By: cortinico Differential Revision: D34304255 fbshipit-source-id: d4e2b0bda56708769603be6f164e6bf89997fd93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This Diff moves the
SegmentedComponentIOS
away from the core of React Native to move forward with the Lean Core effortDifferential Revision: D34304255