Add "exports" special case handling for @babel/runtime #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46107056 |
huntie
added a commit
to huntie/metro
that referenced
this pull request
May 24, 2023
Summary: Pull Request resolved: facebook#990 This is a workaround for facebook#984. It adds a specific exception in the resolver for `babel/runtime` to prevent asserting the `"import"` condition name on these modules (when using Package Exports). This is necessary so that the CJS version of these Babel helpers are resolved, which enable CJS/MJS interop for all other modules (given our current strategy of resolving both `"require"` and `"import"` in all other packages and using Babel-driven ESM compatibility). This workaround is removable if/when any of: - babel/babel#15643 is merged and updated in React Native. - We implement dynamic handling of `"require"` and `"import"` conditions via ESM support in a future version of Metro. Changelog: **[Experimental]** Fix `babel/runtime` issue when using Package Exports Differential Revision: D46107056 fbshipit-source-id: e3b8f453d98a45c7b10df1e6c2ff97b4f017529f
|
This pull request was exported from Phabricator. Differential Revision: D46107056 |
Summary: Pull Request resolved: facebook#990 This is a workaround for facebook#984. It adds a specific exception in the resolver for `babel/runtime` to prevent asserting the `"import"` condition name on these modules (when using Package Exports). This is necessary so that the CJS version of these Babel helpers are resolved, which enable CJS/MJS interop for all other modules (given our current strategy of resolving both `"require"` and `"import"` in all other packages and using Babel-driven ESM compatibility). This workaround is removable if/when any of: - babel/babel#15643 is merged and updated in React Native. - We implement dynamic handling of `"require"` and `"import"` conditions via ESM support in a future version of Metro. Changelog: **[Experimental]** Fix `babel/runtime` issue when using Package Exports Reviewed By: motiz88 Differential Revision: D46107056 fbshipit-source-id: 5c34c5b3e1aaec16b998499401c81fadee34c30d
|
This pull request was exported from Phabricator. Differential Revision: D46107056 |
|
This pull request has been merged in 905d773. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a workaround for #984 (and resolves #984). It adds a specific exception in the resolver for
'@babel/runtime'to prevent asserting the"import"condition name on these modules (when using Package Exports). This is necessary so that the CJS version of these Babel helpers are resolved, which enable CJS/MJS interop for all other modules (given our current strategy of resolving both"require"and"import"in all other packages and using Babel-driven ESM compatibility).This workaround is removable if/when any of:
"require"and"import"conditions via ESM support in a future version of Metro.Changelog: [Experimental] Fix
@babel/runtimeissue when using Package ExportsDifferential Revision: D46107056