Skip to content

Commit

Permalink
tests: disable some compiler warnings
Browse files Browse the repository at this point in the history
Disable some compiler warnings that originate from -Wextra in
_QUIC_BASE_COMPILE_OPTIONS.  E.g., without -Wno-sign-compare, we get
oodles of warnings in the tests about comparing unsigned variables
with integer constants.

Signed-off-by: Jeff Squyres <jeff@squyres.com>
  • Loading branch information
jsquyres committed May 16, 2019
1 parent cd7cf42 commit ce90b7d
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions cmake/QuicTest.cmake
Expand Up @@ -66,9 +66,14 @@ function(quic_add_test)
)
# make sure googletest and fizz are built first
add_dependencies(${QUIC_TEST_TARGET} googletest ${FIZZ_TARGET})

# Per https://github.com/facebookincubator/mvfst/pull/9, disable some warnings
# in the tests that come from -Wextra in _QUIC_BASE_COMPILE_OPTIONS.
target_compile_options(
${QUIC_TEST_TARGET} PRIVATE
${_QUIC_BASE_COMPILE_OPTIONS}
-Wno-sign-compare
-Wno-inconsistent-missing-override
)
target_link_libraries(${QUIC_TEST_TARGET} PRIVATE
"${QUIC_TEST_DEPENDS}"
Expand Down

0 comments on commit ce90b7d

Please sign in to comment.