-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build issues #1
Comments
What version of boost are you using? |
I can't repro it yet (with boost 1.65). But can you locally apply this patch and try running it again:
|
@udippant I can repro on boost-1.58. Your patch doesn't work as well :( I'll do a bisect on boost.variant, we might need to adjust our minimum required boost version. |
@udippant - This is fixed in boostorg/variant@b365068 which is in Boost 1.62. |
Summary: Fix for issue #1 Reviewed By: siyengar Differential Revision: D15172405 fbshipit-source-id: 3e935ae42e445ae605b8e55e080ff7502bafaa83
Summary: Fix for #1 The issue is fixed in boostorg/variant@b365068 (1.62) Reviewed By: yangchi Differential Revision: D15182758 fbshipit-source-id: d6886a74fbf817dafa22494361f7f00d5a25af26
So just to be clear, the fix is to upgrade to boost >= 1.62? |
@fcangialosi yes, the boost lib should at least be at 1.62 (I have landed a change on cmake to require it now) |
(for future reference: i had a bit of trouble updating boost on my machine so I just spun up a new machine with ubuntu 18.04, which gets boost 1.65 by default, and that worked well) |
I have the same question: running build_helper.sh, it seems all of the dependencies have built correctly, but when it gets to the end and tries to build mvfst itself, I get the following compiler error:
|
Summary: As per design, we are not supposed to honor duplicate byte event registrations. Duplicate is defined by a registration for the same <stream ID, stream offset, callback*> tuple twice. Currently, there is a bug where-in we can register the same byte event a second time *if* there is another byte event for a higher offset that is registered in-between, for the same stream. Example Sequence that triggers the bug: 1. Registration for Stream ID =10, offset = 50, callback = A. This will be successful. 2. Registration for Stream ID = 10, offset = 55, callback = <doesn't matter>. This will be successful. 3. Registration for Stream ID = 10, offset = 50, callback = A. This is a duplicate of #1. This *should not* be honored, but it was being honored (this was the bug). This commit fixes the bug, #3 will return INVALID_OPERATION. Reviewed By: bschlinker, lnicco Differential Revision: D27946237 fbshipit-source-id: f9751ac90159284f86a285e5e0ebb23b83041d2a
using:
running
build_helper.sh
, it seems all of the dependencies have built correctly, but when it gets to the end and tries to build mvfst itself, I get the following compiler error:The text was updated successfully, but these errors were encountered: