build_helper: Optionally allow building without jemalloc #14
Conversation
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
| @@ -46,6 +46,12 @@ if [ -z "${BUILD_DIR-}" ] ; then | |||
| mkdir -p $BUILD_DIR | |||
| fi | |||
|
|
|||
| if [[ ! -z $MVFST_FOLLY_USE_JEMALLOC ]]; then | |||
There was a problem hiding this comment.
You can add a flag option on the line # 24 as well (and update the usage)
There was a problem hiding this comment.
nit: Can you use -n instead of ! -z?
Looks good overall.
|
Looks like the travis build is running into a time limit: https://travis-ci.com/facebookincubator/mvfst/builds/111963309#L9510 |
|
@akshayknarayan you'll need to sign the CLA before I can import your commit. |
akshayknarayan
force-pushed
the
no-jemalloc
branch
from
16a9222
to
aa91085
Compare
|
@udippant is there something further I need to do? I have emailed cla@fb.com but haven't gotten a response. |
|
@akshayknarayan - your CLA status should be resolved now. |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
@udippant has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
akshayknarayan
force-pushed
the
no-jemalloc
branch
from
aa91085
to
5f5bd23
Compare
There was a problem hiding this comment.
@udippant has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
As a workaround for facebook/folly#976, modify build_helper.sh to allow disabling jemalloc use by passing the appropriate argument to the cmake invocation on folly.