Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use C++17 #157

Closed
wants to merge 1 commit into from
Closed

Use C++17 #157

wants to merge 1 commit into from

Conversation

deadalnix
Copy link
Contributor

Dependencies started using C++17 so it's required by now and it seems there is some ABI breakage with fizz.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 1, 2020
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjoras has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@deadalnix deadalnix deleted the mvfstcpp17 branch September 4, 2020 13:44
@facebook-github-bot
Copy link
Contributor

@mjoras merged this pull request in b2151a7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants