Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support index-only scans for type DOUBLE #36

Closed
hermanlee opened this issue Sep 28, 2015 · 1 comment
Closed

Support index-only scans for type DOUBLE #36

hermanlee opened this issue Sep 28, 2015 · 1 comment
Assignees
Labels

Comments

@hermanlee
Copy link
Contributor

Issue by spetrunia
Friday Apr 24, 2015 at 00:50 GMT
Originally opened as MySQLOnRocksDB#56


(branching this off from issue #26)

Currently, index-only scans are not supported for column type DOUBLE.
Testcase:

create table t31 (pk int auto_increment primary key, key1 double, key(key1)) engine=rocksdb;
insert into t31 values (),(),(),(),(),(),(),();
explain select key1 from t31 where key1=1.234;

It is actually possible to restore double from its mem-comparable form and thus support index-only scans.
See filesort.cc: void change_double_for_sort(double nr,uchar *to) for the code that needs to be inverted.

@jkedgar
Copy link
Contributor

jkedgar commented Dec 14, 2015

@jkedgar jkedgar closed this as completed Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants