NGSessionPool poolSize always zero?

[jsoroka]

I think this is a mistake.

NGSessionPool(NGServer server, int poolsize) {
    this.server = server;
    this.poolSize = Math.min(0, poolsize);

    pool = new NGSession[poolSize];
    poolEntries = 0;
}

If poolsize is negative, an exception is thrown. If poolsize is positive, poolSize is zero.

[lauri-elevant]

Yes, does seem like none of the session pooling codepaths have never executed :) Seems to work fine though..

[jsoroka]

Originally I thought this project created a pool of JVMs, because it would be so difficult to make it work properly with a single JVM. But that's apparently what it's trying to do, with some tricks and an accidentally unbounded thread pool.

Instead of making a pull request that opens up those previously unexecuted codepaths, here's one #59 that updates the code to make explicit what it has been doing in practice anyway, since at least 2012.