Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing various TODOs and minor cleanups #127

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Addressing various TODOs and minor cleanups #127

merged 1 commit into from
Feb 2, 2021

Conversation

kevinlewi
Copy link
Contributor

@kevinlewi kevinlewi commented Jan 31, 2021 •
edited

  • Removing use of NONCE_SIZE and using NonceLen type instead
  • Fixing digital locker example
  • Modularizing the serialization of various messages when used in AKE section

Closes #124 and #126

@kevinlewi kevinlewi linked an issue Feb 1, 2021 that may be closed by this pull request
Digital locker example should encrypt payload in last step of login #126
Closed
huitseeker
huitseeker approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great, thanks for the rename of NONCE_LEN in particular.

nit: there's an .unwrap() in the initialization of client_login_finish_result in test_credential_finalization that could be a ?

@kevinlewi kevinlewi merged commit 9d3963f into facebook:master Feb 2, 2021
@PaulGrandperrin PaulGrandperrin mentioned this pull request Feb 3, 2021
Closed
@kevinlewi kevinlewi deleted the cleanups_1 branch July 14, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Digital locker example should encrypt payload in last step of login Consider renaming OpenedEnvelope struct
3 participants
@kevinlewi @huitseeker @facebook-github-bot