Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licensing issues #9

Closed
Zarathecat opened this issue Apr 29, 2015 · 6 comments
Closed

Licensing issues #9

Zarathecat opened this issue Apr 29, 2015 · 6 comments

Comments

@Zarathecat
Copy link

Main issue:

I'm interested in cloning and modifying this repo, but after checking
the licensing, I'm worried that I can't legally do that yet. At the moment,
some makefiles and setup scripts say only 'Copyright Facebook.
All Rights Reserved.' (with no mention of the GPLv2), so I don't think
I can currently distribute them.

If the intent of the licensing is to allow people to distribute and modify all
files in the repo, then Facebook may wish to license those files differently
(eg: make it explicit within the files that they are licensed under GPLv2).
I'm not an expert, but I'd rather not distribute/modify the
contents of the repo until this is clarified within the repo itself, and I
think other potential contributors may feel similarly worried.

Other, smaller things:

The'All Rights Reserved' statement no longer has legal weight and conflicts with
the GPL; see the conversation here:
https://lists.debian.org/debian-legal/2007/06/msg00253.html
for more. The address of the Free Software Foundation is also out of date in
some files.

@oridb
Copy link
Contributor

oridb commented Apr 29, 2015

Thanks for bringing this to our attention -- The intent is definitely to allow people to redistribute this code, and the license header is definitely something that we need to fix.

We're planning on a new push with several fixes in the near future -- I'll make sure we update the licenses to GPLv2 along with that.

@Zarathecat
Copy link
Author

Brilliant, thank you. :)

@faybr
Copy link

faybr commented May 5, 2015

Hi - do you have any plan for when the new push will be?

@ghost
Copy link

ghost commented Aug 4, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

@johnz00
Copy link

johnz00 commented Oct 1, 2015

Hi, has there been any progress on updating the licenses, or with the latest push? Thanks!

@oridb
Copy link
Contributor

oridb commented Oct 1, 2015

If you look at the source files, you should see that the license is documented more clearly in the source files.

@oridb oridb closed this as completed Oct 1, 2015
facebook-github-bot pushed a commit that referenced this issue Apr 16, 2019
Summary:
1. move bic-util from minipack to common
2. add gpiolib of minipack and wedge400 to bic-util
Pull Request resolved: facebookexternal/openbmc.celestica#9

Test Plan: able to use bic-utils

Reviewed By: mikechoifb

fbshipit-source-id: d941e7cc05
facebook-github-bot pushed a commit that referenced this issue Mar 4, 2020
Summary:
Add fpga_ver.sh script for Elbert

Testing:None
Pull Request resolved: facebookexternal/openbmc.arista#9

Reviewed By: joancaneus

fbshipit-source-id: 50f2c12f61
facebook-github-bot pushed a commit that referenced this issue Apr 4, 2022
Summary:
Mterm server modification for Cisco Churchillmono.

Borrowed from reference platforms to access host from BMC. The mterm server changes pointing server to the right tty service so that the appropriate UART is redirected. The client for this will be used via the sol.sh which will be introduced in openbmc-utils. Realized by modifying the systemd service file.

Default baudrate defined is 57600 (same as the requirement), so no changes were made there.

X-link: facebookexternal/openbmc.cisco#9

Test Plan:
1. Ensure mterm server is running with the desired tty.
2. Ensure the lock file is created as mentioned in the service file

UT:
```
root@bmc-oob:~# ps | grep wedge
  336 root      1392 S    /usr/local/bin/mTerm_server wedge /dev/ttyS4
root@bmc-oob:~# ls /var/lock/mTerm_wedge
/var/lock/mTerm_wedge
 ```

Reviewed By: mikechoifb

fbshipit-source-id: 9be6ddc1ec72aa8ac147bc6dd6ac8f7f0f6ed3e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants