Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sleuthkit to v4.3.0 (#2545) #2557

Merged
merged 1 commit into from Sep 28, 2016
Merged

Update sleuthkit to v4.3.0 (#2545) #2557

merged 1 commit into from Sep 28, 2016

Conversation

danielbayerlein
Copy link
Contributor

I've updated the dependency sleuthkit to v4.3.0 - fix #2545
Happy Hacktoberfest!

@osqueryer
Copy link

Can one of the osquery admins reply with "ok to test" to kick off a build...

2 similar comments
@osqueryer
Copy link

Can one of the osquery admins reply with "ok to test" to kick off a build...

@osqueryer
Copy link

Can one of the osquery admins reply with "ok to test" to kick off a build...

@ghost
Copy link

ghost commented Sep 28, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@ghost ghost added the cla signed Automated label: Pull Request author has signed the osquery CLA label Sep 28, 2016
@ghost
Copy link

ghost commented Sep 28, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@theopolis
Copy link
Member

ok to test

@theopolis theopolis added libraries For things referring to osquery third party libraries Hacktoberfest labels Sep 28, 2016
@ghost ghost added the cla signed Automated label: Pull Request author has signed the osquery CLA label Sep 28, 2016
@osqueryer
Copy link

👎 The commit c6e1421 (Job results: 3393) failed one or more tests (OS X/Linux).

@danielbayerlein
Copy link
Contributor Author

@theopolis Unfortunately, the build "aws-centos7" was not successful. Any idea?

@facebook-github-bot facebook-github-bot added the cla signed Automated label: Pull Request author has signed the osquery CLA label Sep 28, 2016
@theopolis
Copy link
Member

Right, it's the same root cause as #2510 the Data::Dumper module is not included in CentOS7's default perl install. I've added this (perl-Data-Dumper) to the build host provision since it's rather 1-off.

Reference: https://rt.cpan.org/Public/Bug/Display.html?id=97846

@theopolis
Copy link
Member

theopolis commented Sep 28, 2016

Let's give it another try and see if my changes allow sleuthkit to build from source.

@theopolis
Copy link
Member

ok to test

@theopolis
Copy link
Member

Working now: https://jenkins.osquery.io/job/osqueryPullRequestBuild/TargetSystem=aws-centos-7/3394/console I'll let the builds finish and on success will merge. Thanks @danielbayerlein!

@facebook-github-bot facebook-github-bot added the cla signed Automated label: Pull Request author has signed the osquery CLA label Sep 28, 2016
@danielbayerlein
Copy link
Contributor Author

@theopolis Thanks a lot! 👍

@theopolis theopolis merged commit 80de6e3 into osquery:master Sep 28, 2016
@danielbayerlein danielbayerlein deleted the update-sleuthkit branch September 28, 2016 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Automated label: Pull Request author has signed the osquery CLA Hacktoberfest libraries For things referring to osquery third party libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants