Fix acceleration code to use RapidJSON properly #4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
cla signed
obelisk
changed the title
muffins
previously requested changes
Mar 30, 2018
|
ok to test |
muffins
dismissed
their stale review
This LGTM, would you mind filing a follow-up issue to land tests for this?
trizt
pushed a commit
to trizt/osquery
that referenced
this pull request
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The acceleration code was not updated to reflect the proper typing of RapidJSON deserialization, thus we were always failing the IsString() check and never running accelerated mode.
This is just a simple fix to use the API correctly. I'm marking it as
API Changebecause in theory would have worked before if you made accelerate a string (even though it was supposed to be an int) and now it must be an int.