Removing macOS kernel module #4572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
cla signed
|
How do you know this is dead code? Did you hit up Slack to see if anyone is using this? |
|
there is no way to build it :( |
|
I brought this up in office hours, no one spoke up about even trying to use it and other people were happy to see it go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel module has gone unused for many versions of osquery and is no longer supported. In addition to being dead code, it also can be confusing for new people to the project to see the kernel folder thinking that osquery relies on a kernel extension.
This diff removes the code from the repo, the documentation on it, and all the build support from our cmake system.