New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround Curl bug where Proxy headers are not included in header_size #48

Merged
merged 1 commit into from May 16, 2014

Conversation

Projects
None yet
2 participants
@DaMouse404
Contributor

DaMouse404 commented May 9, 2014

Versions of Curl prior to 7.30.0 do not properly account for additional headers injected via proxies when calculating header_size. This is a quick workaround based on:
googleapis/google-api-php-client#117

This detects the commonly added proxy header and removes the length so that it returns correctly. It has no effect if the curl version is higher than 7.30.0.

Ref:
googleapis/google-api-php-client#117
https://bugs.php.net/bug.php?id=63894
http://curl.haxx.se/mail/lib-2013-04/0189.html

@gfosco

This comment has been minimized.

Contributor

gfosco commented May 15, 2014

Couple things:
Please change the function curlProxyBug to needsCurlProxyFix and make it a private static function.
Please rebase since changes have caused conflicts.

@DaMouse404

This comment has been minimized.

Contributor

DaMouse404 commented May 16, 2014

Thanks for your feedback, I have updated my branch.

gfosco added a commit that referenced this pull request May 16, 2014

Merge pull request #48 from DaMouse404/curl-proxy-bug
Workaround Curl bug where Proxy headers are not included in header_size

@gfosco gfosco merged commit 595512b into facebook:master May 16, 2014

@gfosco

This comment has been minimized.

Contributor

gfosco commented May 16, 2014

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment