This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Workaround Curl bug where Proxy headers are not included in header_size #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Couple things: |
|
Thanks for your feedback, I have updated my branch. |
gfosco
pushed a commit
that referenced
this pull request
May 16, 2014
Workaround Curl bug where Proxy headers are not included in header_size
|
Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions of Curl prior to 7.30.0 do not properly account for additional headers injected via proxies when calculating header_size. This is a quick workaround based on:
googleapis/google-api-php-client#117
This detects the commonly added proxy header and removes the length so that it returns correctly. It has no effect if the curl version is higher than 7.30.0.
Ref:
googleapis/google-api-php-client#117
https://bugs.php.net/bug.php?id=63894
http://curl.haxx.se/mail/lib-2013-04/0189.html