Skip to content
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.

Use time progress to determine basic animation end. #141

Merged
merged 1 commit into from Sep 26, 2014

Conversation

sergiou87
Copy link

If the timing function goes over 1.0 the animation stops at that point (issue #91). This commit should fix that.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@sergiou87
Copy link
Author

Please, can you take a look to your Travis CI configuration? It seems like it's trying to install xctool when it's already installed, and it ends up with an error.

Thanks!

@nikita-leonov
Copy link

Hey guys from facebook, what is required for this pull request to be reviewed? It is more than a month in review.

@kimon kimon merged commit 18f69cc into facebookarchive:master Sep 26, 2014
@kimon
Copy link
Contributor

kimon commented Sep 26, 2014

ah, apologies for the delay. the changes looked good; at the time CI builds were failing for other reasons. the CI builds are fixed, I confirmed unit tests pass, these changes look good!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants