This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Display heap graph in website #1265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwli229
requested review from
cblappert,
hermanventer,
NTillmann and
jeffreytan81
|
|
jeffreytan81
approved these changes
Dec 14, 2017
|
Just to confirm: the new UI is not displayed by default right? What is the UI action to trigger the display? |
|
For "TODO: add a legend to the UI describing what the different shapes and colors mean", you added it in this diff. |
|
The graph UI is hidden by default. It is triggered by a button click on the "SHOW HEAP" blue button on the top right. I have updated the summary to remove the TODO. This is the view when the page is first loaded: |
There was a problem hiding this comment.
@JWZ2018 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: add heap graph visualization to website
Moved from #1243
Summary:
Test Plan: