This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Extract out website changes for REPL.js #1310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. For some reason I have small UI bugs on the current version of prepack.io:
But when I try this PR locally everything works fine so let's land it and see if it fixes the production website. I'll leave someone from the prepack team approve the PR. @hermanventer or @NTillmann? |
There was a problem hiding this comment.
@trueadm is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks for reviewing! I believe the issue you saw was already fixed in this PR: #1298 It probably hasn't been deployed yet. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: none
Extracted our website changes from commit: 1dbefcb
This was done as suggested in 1dbefcb#commitcomment-26606024.