This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Re-adds Flow parsing and stripping when option is enabled #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueadm
force-pushed
the
strip-flow-option
branch
from
821984c
to
43f9da4
Compare
gaearon
approved these changes
Feb 13, 2018
trueadm
commented
Feb 13, 2018
| @@ -0,0 +1,78 @@ | |||
| /** | |||
There was a problem hiding this comment.
This file is exactly the same code we had before we removed it.
trueadm
force-pushed
the
strip-flow-option
branch
from
43f9da4
to
fa218aa
Compare
There was a problem hiding this comment.
@trueadm is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: adds option to parse and strip Flow annotations
In a tweet I made at the end of last year I linked to a REPL example that contained Flow type annotations. The example is now broken as we removed Flow type annotation parsing. :(
This PR adds this back behind the option
stripFlowwhich is now enabled by default on the REPL and for React tests. I've also added a test to match the REPL for regression checking so this doesn't happen.