This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Adding lazyObjectsRuntime option to the Prepack Website #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTillmann
reviewed
Feb 21, 2018
website/js/repl.js
Outdated
| type: "string", | ||
| name: "lazyObjectsRuntime", | ||
| defaultVal: "", | ||
| description: "Enable lazy objects feature and specify the JS runtime that support this feature." |
There was a problem hiding this comment.
Thanks for pointing out. Will commit a fix shortly.
jeffreytan81
approved these changes
Feb 22, 2018
There was a problem hiding this comment.
@phanipattapu is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue #1282 although the issue also requests for --additionalFunctions option which is not part of this commit. User should now be able to see --lazyObjectsRuntime option in the options list on https://prepack.io/repl.html. Ideally this should be an enum but this will accept a freeform string in this revision.