This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Removing --abstractEffectsInAdditionalFunctions option #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't "// abstract effects" be removed from the test cases as part of this change? |
Release notes: Removing --abstractEffectsInAdditionalFunctions option It is now the new default, as nothing seems to depend on the old behavior.
NTillmann
force-pushed
the
RemoveAbstractEffectsInAdditionalFunctions
branch
from
e379bc3
to
ce54590
Compare
|
Thanks for the feedback, should be all addressed now. |
hermanventer
approved these changes
Mar 20, 2018
There was a problem hiding this comment.
@NTillmann is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: Removing --abstractEffectsInAdditionalFunctions option
It is now the new default, as nothing seems to depend on the old behavior.