This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Fix test runner and don't swallow invariant failures #2155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTillmann
reviewed
Jun 25, 2018
src/realm.js
Outdated
| @@ -885,6 +887,7 @@ export class Realm { | |||
| effects1 = Widen.widenEffects(this, effects1, effects2); | |||
| } | |||
| } catch (e) { | |||
| if (e instanceof InvariantError) throw e; | |||
There was a problem hiding this comment.
Why would it ever be okay to swallow random errors? What about SyntaxError or RangeError or TypeError? Any error that we don't know if benign for sure is by default a bug.
…crept in because of it.
There was a problem hiding this comment.
@hermanventer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: Fix test runner and don't swallow invariant failures
The recent changes to make the serializer test runner deal with promises, caused it to list every test that follows a failing test as also failing.
I've also noticed that invariant failures can get swallowed. And as a result of that some test cases that should have failed with false invariants showed up as passing.
Those failures were recently introduced by PR #2134. It boils down to a single line fix, which is also included with this.