This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Improved reported error for PP1003 #2305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueadm
reviewed
Jul 23, 2018
src/serializer/functions.js
Outdated
| let fun1Name = | ||
| this.functionExpressions.get(fun1) || | ||
| fun1.intrinsicName || | ||
| fun1.__originalName || |
There was a problem hiding this comment.
Rather than doing intrinsicName || __originalName every time, we should create a helper function like have with React, getFunctionName(). Functions might also have a name as a property, and neither of these ways will get it, so it's best if we start making the name getting part generic in the code base.
trueadm
approved these changes
Jul 24, 2018
NTillmann
approved these changes
Jul 24, 2018
There was a problem hiding this comment.
@cblappert is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous error message:
Property access conflicts with write in optimized function (unknown function) at 11:11 to 11:16New error message:
Write to property "func" on <unnamed object> at optimized function fn[20:13 22:22] conflicts with access in function nested[11:11]Output generated off "Failure 2" in issue #2252